Re: [PATCH 1/3] d3dx10: Implement D3DX10CreateTextureFromMemory initially.

[Matteo Bruni]

On Thu, Jun 24, 2021 at 5:43 AM Ziqing Hui  wrote:
> > > - *texture = (ID3D10Resource *)texture_2d;
> >
> > I wonder if that is supposed to be set to NULL on failure. Can you
> > please add a test for that?
>
> OK, I'll add more test for that.
> > > - if (hr != S_OK)
> > > -
> > >    return E_FAIL;
> > > - return S_OK;
> >
> > Is this necessary? As opposed to a simple "return hr;".
>
> The tests show that D3DX10CreateTextureFromMemory will always return E_FAIL on failure. See: https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/d3dx10_43/tests/d3dx1...

The current tests still pass for me with just "return hr;".