Re: [PATCH] wined3d: Allow constant buffers to be forced to be write-mappable.

[Henri Verbeet]

On Mon, 6 Sept 2021 at 15:36, Jan Sikorski  wrote:
> diff --git a/dlls/wined3d/wined3d_main.c b/dlls/wined3d/wined3d_main.c
> index 6e93b8dc683..a059598ec21 100644
> --- a/dlls/wined3d/wined3d_main.c
> +++ b/dlls/wined3d/wined3d_main.c
> @@ -394,6 +394,11 @@ static BOOL wined3d_dll_init(HINSTANCE hInstDLL)
>                  wined3d_settings.renderer = WINED3D_RENDERER_NO3D;
>              }
>          }
> -
>    if (!get_config_key_dword(hkey, appkey, "WriteMappableConstantBuffers", &tmpvalue) && tmpvalue)
> -
>    {
> -
>        TRACE("Forcing all constant buffers to be write-mappable.\n");
> -
>        wined3d_settings.write_mappable_cbuffers = TRUE;
> -
>    }
> }

We tend to use the same name for the registry setting as for the field
name in the wined3d_settings structure for new settings. (So in this
case that would then be "write_mappable_cbuffers" for the registry
setting as well, or perhaps e.g. "cb_access_map_w" for both.)