James Hawkins wrote:
There are several things wrong with this patch:
- It's way too large. Please split it up.
- No tests. You need to write tests to back up these changes.
Are tests necessary for simple stubs? I don't know what kind of tests can be written for stubs, except tests for wrong input parameters.