On Fri, 24 Feb 2006 12:24:45 +0100 Alexandre Julliard julliard@winehq.org wrote:
Phil Krylov phil@newstar.rinet.ru writes:
On Tue, 21 Feb 2006 14:08:38 -0800 Lei Zhang leiz@ucla.edu wrote:
Hi Phil,
Ya, it's a typo. Thanks for catching it.
Could you kindly fix it then? As this patch was accepted unfixed.
I accepted the patch because I don't see how pCurItem could be NULL in that loop (or rather, it could be NULL, but in that case we'll crash before coming back to the loop test). Am I missing something?
Yes, you're right. It can't be NULL because of an earlier test:
para->member.para.nCharOfs + item->member.run.nCharOfs + nEnd - nLen >= nMin
But this is very inevident.
-- Ph.