Re: [PATCH] msvcm90: Add manifest.

[Dmitry Timoshkov]

Hi Piotr,

Piotr Caban  wrote:
> On 9/18/20 11:58 AM, Dmitry Timoshkov wrote:
> > +<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
> > +<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
> > -
> >
> > <assemblyIdentity type="win32" name="Microsoft.VC90.CRT" version="9.0.30729.6161" processorArchitecture="" publicKeyToken="1fc8b3b9a1e18e3b"/>
> > -
> >
> > <file name="msvcr90.dll"/>
> > -
> >
> > <file name="msvcp90.dll"/>
> > -
> >
> > <file name="msvcm90.dll"/>
> >
> > +</assembly>
>
> I don't like the idea of having 3 copies of the same manifest (and 
> updating all of them on e.g. version change). I think it's better to 
> copy all the files specified in wine manifest in setupapi. I've sent a 
> patch that does it:
> https://source.winehq.org/patches/data/193126

Yes, that patch also works, thanks. I had wrong impression that all 3 files
mentioned in manifest should have their own manifest included in each DLL,
however it appears that's not the case.