11 Jan
2013
11 Jan
'13
10:08 a.m.
On 1/11/2013 14:58, Dmitry Timoshkov wrote:
Nikolay Sivov bunglehead@gmail.com wrote:
Who is responsible for freeing icon handle? I guess it should be done here cause your implementation doesn't free it either.
You are right, DestroyIcon() is missing at the end of the test. Consider that as a feature, the tests are not supposed to free all the allocated resources, it's a waste of time :)
Fixing leaks like that is not optional. One reason to do this is to make valgrind output clean so it contains only real leaks in code. Another reason is that test could serve as an example of API usage.