Re: [PATCH v6 2/7] ntdll/tests: Add broken results NtAllocateVirtualMemory tests on w1064v1809

[Huw Davies]

On Fri, May 31, 2019 at 11:11:46AM +0200, Rémi Bernon wrote:
> On Thu, 2019-05-30 at 13:21 +0100, Huw Davies wrote:
> > On Wed, May 29, 2019 at 03:13:08PM +0200, Rémi Bernon wrote:
> > >  if (status == STATUS_SUCCESS) ok(VirtualFree(addr2, 0,
> > >
> > > MEM_RELEASE), "VirtualFree failed\n");
> > >  /* AT_ROUND_TO_PAGE flag is not supported for
> > >
> > > NtAllocateVirtualMemory */
> > > @@ -66,7 +69,9 @@ static void test_AllocateVirtualMemory(void)
> > >      status = pNtAllocateVirtualMemory(GetCurrentProcess(), &addr2,
> > > 0, &size, MEM_RESERVE |
> > >                                        MEM_COMMIT |
> > > AT_ROUND_TO_PAGE, PAGE_EXECUTE_READWRITE);
> > >      todo_wine
> > > - ok(status == STATUS_INVALID_PARAMETER_5,
> > >
> > > "NtAllocateVirtualMemory returned %08x\n", status);
> > > - ok(status == STATUS_INVALID_PARAMETER_5 ||
> > > -
> > >   broken(status == STATUS_INVALID_PARAMETER) /* w1064v1809
> > >
> > > */,
> > > -
> > >   "NtAllocateVirtualMemory returned %08x\n", status);
> >
> > And again.
> >
> > Huw.
>
> Here Wine returns STATUS_INVALID_PARAMETER, like w1064v1809, but not
> like previous Windows version, therefore the todo_wine. Should we
> detect the emulated windows version to be sure the returned status is
> consistent with it, or can the todo_wine be dropped?

So they've 'fixed' Windows to behave like Wine - cool! ;-)

Yes, in that case just accept STATUS_INVALID_PARAMETER as well and remove
the todo_wine.

Huw.