Re: bug fix: Prevented strlen(NULL) in PRINTDLG_CreateDevNames()

[Stefan Dösinger]

Am Sonntag, 25. November 2007 12:35:36 schrieb Jorma Laaksonen:
> Hello!
>
> wine-0.9.49 (as well as many earlier versions) seems to crash when
> PRINTDLG_CreateDevNames() is for some reason called with DeviceDriverName
> equal to NULL.  The real cause of this problem might be somewhere else
> where the NULL is assigned, but this simple fix prevents NULL being
> passed to strlen().

If you suspect that the real problem is somewhere else, it is recommended to 
write a test case to see how Windows deals with this situation. Windows could 
return an error if the device driver name is NULL. If Windows crashes as 
well, your patch would only hide a bug instead of fixing it.