Am Montag, den 25.01.2010, 10:47 +0100 schrieb Paul Vriens:
On 01/25/2010 09:37 AM, Michael Karcher wrote:
Am Montag, den 25.01.2010, 15:27 +0800 schrieb Dmitry Timoshkov:
The current code misdetects both Windows XP and Wine as Win9x and skips some tests due to this. The SetParent tests were not passing on XP, so this patch also removes the tests that fail on XP SP3.
I just checked with a XP-SP3 box on winetestbot and added the flag to show the winetest successes:
https://winetestbot.geldorp.nl/JobDetails.pl?Key=420
This clearly shows that the tests are run. I'm not saying they run on every XP box btw.
It shows only lines 3236 to 3250 being run - these are the tests that are not protected by the broken is_win9x check.
The interesting tests this patch touches and I claim (a) not to be run and (b) failing on some systems like my XP SP3 box are in lines 3254 to 3260 and the following check_parents calls.
I hope I didn't miss something important in that analysis.
Regards, Michael Karcher