Hi Dan,
On Wed, May 25, 2011 at 10:31 AM, Dan Kegel dank@kegel.com wrote:
A comment or two about the layout of the output buffer might be nice.
The layout doesn't group all values, param names, or defaults, so it actually seems to be best described using loops. Does the the following comment help summarize the layout?
/* effects buffer layout: * * D3DXEFFECTINSTANCE effects[num_materials]; * for (effect in effects) * { * D3DXEFFECTDEFAULT defaults[effect.NumDefaults]; * for (default in defaults) * { * *default.pParamName; * *default.pValue; * } * } */
Can materials and material_ptr be const pointers?
ID3DXBuffer_GetBufferPointer doesn't take a const, so no for materials, but material_ptr can be const.
The rest of the advice I took (see the attached patch).
Thanks for the patch review.