On Thu, Jan 10, 2019 at 10:00:26PM +0100, Michael Stefaniuc wrote:
On 1/10/19 5:42 PM, Andrew Eikum wrote:
Looks good to me, but I think it should be deferred until after 4.0 since it doesn't fix a regression.
Well, bug fixes should be fine at the moment too. A Wine-Bug tag is highly recommended though.
I admit I don't really understand the rules of code freeze. I thought it was supposed to be only regression fixes, or extremely obvious bug fixes. It seems really weird to me that we accept cleanup patches during code freeze. I don't know, it's not my call.
Andrew