Re: [wined3d] Add DF16 and DF24 formats

[Vijay Kiran Kamuju]

Well I have to ask other users there if it helps them.
As It did not show any FIXME's for those two formats.

I think I have to remove the stencil there for D16 and D24, Its a copy
paste error.

I am checking the doc right now.

Thanks,
VJ

On Fri, Apr 18, 2014 at 3:13 PM, Henri Verbeet  wrote:
> On 18 April 2014 16:46, Vijay Kiran Kamuju  wrote:
> > - {WINED3DFMT_DF16,                       0,  0,  0,  0,  16, 24,  8,  0,    0,   0,     0},
> > - {WINED3DFMT_DF24,                       0,  0,  0,  0,  24, 24,  8,  0,    0,   0,     0},
>
> This is pretty much just wrong.
> > - {WINED3DFMT_DF16,                   GL_DEPTH24_STENCIL8_EXT,          GL_DEPTH24_STENCIL8_EXT,                0,
> > -
> >        GL_DEPTH_STENCIL_EXT,       GL_UNSIGNED_INT_24_8_EXT,         0,
> > -
> >        WINED3DFMT_FLAG_TEXTURE | WINED3DFMT_FLAG_POSTPIXELSHADER_BLENDING | WINED3DFMT_FLAG_FILTERING
> > -
> >        | WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL,
>
> WINED3DFMT_FLAG_STENCIL is suspicious here, since afaik these are
> depth only formats.
>
> Note that you can't expose these formats without also implementing
> "Fetch-4", since that's implied by DF24. See also
> http://developer.amd.com/wordpress/media/2012/10/Advanced-DX9-Capabilities-f....
> Does this patch help any application?