On Mon, 19 Nov 2007, Alexandre Julliard wrote:
The members of EMRCREATEDIBPATTERNBRUSHPT are of type DWORD, so comparing them for >= 0 is a noop which always evaluates to true.
Gerald
ChangeLog: Remove four unnecessary comparisions of DWORD variables for >= 0.
Validating the record is not unnecessary, it just needs to be done correctly by checking for wraparounds etc.
I had expected this comment for a different patch of mine. In dlls/gdi32/enhmetafile.c we are just reading existing records, so I'm not sure what you have in mind here?
Gerald