Hi Huw,
On 03/06/2020 11:52, Huw Davies wrote:
On Mon, May 25, 2020 at 03:02:34PM +0300, Gabriel Ivăncescu wrote:
Fixes a regression introduced by 9bc6f004ceccf3963584a4f7f4681b5c0578c214, which caused the assert to fail under specific circumstances, and break some apps.
Could you add a test? Also, which apps? I don't see any bugs with this SHA1 listed as a regression.
Huw.
Yeah, unfortunately there's no bug report about it. Someone reported it to me and bisected the regression awhile ago when I sent it the first time, but they use an old VST plugin called "Audio Damage EOS", which is not available anymore (it's been superseded for a long time, apparently).
So I've been unable to test exactly what's going on, but going by the commit they bisected and adding this check, they said it fixed the problem—unfortunately I haven't been able to get in contact with them since.
I'll try and see if I can reproduce this in tests in some way or what exactly causes it.
Thanks, Gabriel