Re: Re: [2/2] ddraw: add dsurface dimension tests, try 11

[Patrick Rudolph]

Hi Henri,
thanks for reviewing.
> > -
> >    /* 6: Test maximum surface height */
> > -
> >    {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, 
> >
> > DDSCAPS_OFFSCREENPLAIN, 1, 0x10000, DDERR_INVALIDPARAMS},
> > -
> >    /* 7: Test maximum surface width */
> > -
> >    {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, 
> >
> > DDSCAPS_OFFSCREENPLAIN, 0x10000, 1, DDERR_INVALIDPARAMS},
>
> It would perhaps also be useful to verify that e.g. a 1 by 0xffff
> surface actually is allowed.

I've not included the tests for DirectDraw surfaces with dimension 1 by 
0xffff and 0xffff by 1 as they fail on wine. The surfaces are provided 
by Opengl textures and the maximum texture size is less than 0xffff. 
However on Windows these tests pass, if the graphic cards pitch is great 
enough. Stefan pointed out that on old cards this test might fail.
Should I add a separate test for this including a wine_todo ? I guess 
this won't be fixed any time soon...

Regards,
Patrick