Re: [1/3] winex11.drv: Add on-screen PS_USERSTYLE support to pens (bugbot feeding #5)

[Alexandre Julliard]

Daniel  writes:
> @@ -42,29 +42,23 @@ HPEN X11DRV_SelectPen( PHYSDEV dev, HPEN hpen )
>      X11DRV_PDEVICE *physDev = get_x11drv_dev( dev );
>      LOGPEN logpen;
>      int i;
> - EXTLOGPEN *elp = NULL;
> - INT size = GetObjectW( hpen, 0, NULL );
> - if (!GetObjectW( hpen, sizeof(logpen), &logpen ))
> - {
> -
>    /* must be an extended pen */
> -
>    EXTLOGPEN *elp;
> -
>    INT size = GetObjectW( hpen, 0, NULL );
> -
> -
>    if (!size) return 0;
> -
> - if (!size) return 0;
> - else if (size == sizeof(logpen)) {
> -
>    GetObjectW( hpen, sizeof(logpen), &logpen );
> -
>    physDev->pen.ext = 0;
> - } else {

You are changing too much here, there's no reason to duplicate the
GetObject call for the standard case.

Also please make sure to include your full name in your mail headers.