Re: [PATCH v2] dinput: Use the same GUID for Instance and Product

[Zebediah Figura]

On 10/29/18 2:41 PM, Brendan McGrath wrote:
> This matches the behaviour of DirectInput8 native and appears to be
> required for some games to recognise the mouse and keyboard as
> a mouse and keyboard.
> Signed-off-by: Brendan McGrath
>
> Changes since v1:
>    a) Added the signed-off tag; and
>    b) Changed the Unicode equivalent to match the ASCII version
>
> This resulted in no more uses of those GUIDs, so I also cleaned up
> any reference to them
>
> dlls/dinput/device_private.h |  3 ---
>   dlls/dinput/dinput_main.c    |  6 ++----
>   dlls/dinput/keyboard.c       | 11 +++--------
>   dlls/dinput/mouse.c          | 11 +++--------
>   4 files changed, 8 insertions(+), 23 deletions(-)

This seems like it should be testable; can you add tests for this?