Re: [PATCH 0/5] MR322: winex11.drv: Preparation for nulldrv display modes.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/winex11.drv/desktop.c:
>              screen_sizes[size_idx].height > max_height)
>              continue;
>
> -
>        if (screen_sizes[size_idx].width == max_width &&
> -
>            screen_sizes[size_idx].height == max_height)
> -
>            continue;
> -
> -
>        if (screen_sizes[size_idx].width == screen_width &&
> -
>            screen_sizes[size_idx].height == screen_height)
> -
>            continue;
> -

I don't think removing these are harmless. They're there for a reason. For example, max_width and max_height refer to the physical monitor resolution. screen_width and screen_height refer to the user-emulated resolution. If I need to emulate a 2000x1000(in winecfg) on a 4000x2000(physical) monitor, removing these lines will not allow these modes to be used and only the modes listed in screen_sizes can be emulated.