Re: [PATCH 2/2] winealsa.drv: send MIDI events to port subscribers

[Andrew Eikum]

Hi Jacek,

Thanks for the patch series.

On Sun, Feb 09, 2020 at 07:36:46PM +0100, Jacek Konieczny wrote:
> diff --git a/dlls/winealsa.drv/midi.c b/dlls/winealsa.drv/midi.c
> index ab14307917..b5ffa6bf68 100644
> --- a/dlls/winealsa.drv/midi.c
> +++ b/dlls/winealsa.drv/midi.c
> @@ -878,7 +878,7 @@ static DWORD modData(WORD wDevID, DWORD dwParam)
>              snd_seq_ev_clear(&event);
>              snd_seq_ev_set_direct(&event);
>              snd_seq_ev_set_source(&event, port_out);
> -
>        snd_seq_ev_set_dest(&event, MidiOutDev[wDevID].addr.client, MidiOutDev[wDevID].addr.port);
> -
>        snd_seq_ev_set_dest(&event, SND_SEQ_ADDRESS_SUBSCRIBERS, 0);

It looks like using snd_seq_ev_set_subs() might be a better fit here.
> @@ -1047,8 +1047,7 @@ static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize)
>    snd_seq_ev_clear(&event);
>    snd_seq_ev_set_direct(&event);
>    snd_seq_ev_set_source(&event, port_out);
> - snd_seq_ev_set_dest(&event, MidiOutDev[wDevID].addr.client, MidiOutDev[wDevID].addr.port);
> - TRACE("destination %d:%d\n", MidiOutDev[wDevID].addr.client, MidiOutDev[wDevID].addr.port);
> -
>    snd_seq_ev_set_dest(&event, SND_SEQ_ADDRESS_SUBSCRIBERS, 0);

Same here, obviously.

Also, in both patches, please try to match surrounding tab-style. I
know it's already a mess. Or, if you prefer, I can fix it up and
resend with your sign-off. Up to you.

Andrew