Re: [PATCH 3/6] d3drm: Implement IDirect3DRM*_CreateTexture. (v3)

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2016-05-08 um 16:57 schrieb Stefan Dösinger:
> > > - object->d3drm = &d3drm->IDirect3DRM_iface;
>
> Afaics InitFromImage does it anyway. It also causes problems when 
> InitFromImage fails for some reason - you'll decref the d3drm 
> object in the error path below.

Er, I misread this part - InitFromImage doesn't assign texture->d3drm,
and the decref is tied to having an image, not having d3drm set.

Still it seems to be duplicated logic to set this here.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXL2paAAoJEN0/YqbEcdMwsiIP/0q9Hc50GEAB4UFxq0SxSz52
QQutknkDu/M/8ozGSr58xt/SzaSDO+Ij71nNRAf050bEBHuoxpZyqR8zYeW9oSDt
tMLHxm33MIsbb1U2AtqEdl6v/uQHS3weJwqCIUL9m1u6ZvkY119MsM41IWh/Kuim
yqspcGZAp4CPeKNvh5ynQAk49ElUJN1EDQ2fARlRSIAz9BZh2MZc30eIhc/pwQ3Q
sD7Y8TPCVIp8p7r+yVlvAKgdxMTNQOlPg52O04UK54o/UHFyeqv0c8ANxK5Zpa5a
4bHxvCMOXlZw67ML17VGI3tjABhC2fjYg+YeNLS98IACE7YZL/ui7SeRmN3KmTLJ
DwNyIFqjtistwDP8x5rPKnZZmQ09AjNy8tR5vW/XOUf3rmWbtIz+EWMZd/P4zeRc
88kI9JgDZ+niw9yUpcnkxCIdMKZO4cU0gtENYGDJBeL8WF+MTSomiDdTbThYufQs
4XPFgF7LBlbmp6fkOwyypyaKHr2/l7f/K0MTHGsdf8FKeYIOCKcJuKon8oYxGDEo
N3iuZAwqR9CVg2kgajwvddUMq75tz76XPSaXdwG+rMinrv1cNVUMNRjSuvlKosN3
y24Gav7P86WY8LPCAzqwULE1cb0Erule0kvSoMSXEmkIqez6lX41sQxXU0lWDrMy
lvPtRcV8JZhhjklqZ69l
=9sKX
-----END PGP SIGNATURE-----