Re: [PATCH 2/2] vkd3d/tests: Enable ReadFromSubresource() read-back test and remove todo.

[Conor McCarthy]

Hi Józef,

August 1, 2019 5:33 PM, "Józef Kucia"  wrote:
> > - /* WriteToSubresource() is not implemented so upload test data */
> > - transition_resource_state(command_list, src_texture,
> > - D3D12_RESOURCE_STATE_COMMON, D3D12_RESOURCE_STATE_COPY_DEST);
> > - texture_data.pData = dst_buffer;
> > - texture_data.RowPitch = row_pitch;
> > - texture_data.SlicePitch = slice_pitch;
> > - upload_texture_data(src_texture, &texture_data, 1, queue, command_list);
> > - reset_command_list(command_list, context.allocator);
> > - transition_resource_state(command_list, src_texture,
> > - D3D12_RESOURCE_STATE_COPY_DEST, D3D12_RESOURCE_STATE_COMMON);
>
> This makes a bunch of WriteToSubresource() and
> ID3D12Resource_ReadFromSubresource() tests much less interesting.
> Please try to extends tests instead and add this as a separate test
> case as suggested above.

I'm not sure what you mean. The two ReadFromSubresource() tests which follow this do almost nothing useful without the test data. They return S_OK and junk data. This extra code can be deleted if/when WriteToSubresource() is implemented.

Conor