Re: [PATCH vkd3d v4 1/6] vkd3d-shader: Pass a struct vkd3d_shader_register_range to vkd3d_dxbc_compiler_emit_combined_sampler_declarations().

[Henri Verbeet]

On Fri, 25 Jun 2021 at 06:00, Conor McCarthy  wrote:
> static void vkd3d_dxbc_compiler_emit_combined_sampler_declarations(struct vkd3d_dxbc_compiler *compiler,
> -
>    const struct vkd3d_shader_register *resource, unsigned int resource_space, unsigned int resource_index,
> -
>    const struct vkd3d_shader_register *resource, struct vkd3d_shader_register_range resource_range,
>    enum vkd3d_shader_resource_type resource_type, enum vkd3d_shader_component_type sampled_type,
>    unsigned int structure_stride, bool raw, const struct vkd3d_spirv_resource_type *resource_type_info)
>
> {

It's true that the vkd3d_shader_register structure is small enough
that it doesn't really make a difference here, but as a matter of
principle, I think we should pass structure arguments as (const)
pointers. (Here and in subsequent patches.)