On Thu, Jan 11, 2018 at 7:32 PM, Henri Verbeet hverbeet@gmail.com wrote:
On 11 January 2018 at 17:03, Józef Kucia joseph.kucia@gmail.com wrote:
struct vkd3d_device_create_info { D3D_FEATURE_LEVEL minimum_feature_level; vkd3d_signal_event_pfn signal_event_pfn;
- vkd3d_create_thread_pfn create_thread_pfn;
- vkd3d_join_thread_pfn join_thread_pfn; size_t wchar_size;
};
This breaks ABI. That's still kind of ok since we haven't made an actual public release yet, but I think we should add a version or size field to this structure to handle this kind of thing in the future. Alternatively, we could version the vkd3d_create_device() symbol; not sure whether that would be preferred. It's probably not a bad idea to review the API for those kinds of issues before we make a release either.
Yes, I think we need to change and extend the API before the first release. My intent was to eventually introduce a version field or a similar mechanism. However, I have more incompatible changes, and it makes more sense to introduce structure or a similar mechanism after these changes.