Re: [PATCH v2 4/4] winehid: Implement handing internal ioctls

[Sebastian Lackner]

On 14.10.2016 06:25, Aric Stewart wrote:
> Yup, rebased and resent
>
> thanks!
> -aric

Actually I was thinking about an even more simplified solution like:

--- snip ---
static NTSTATUS WINAPI internal_ioctl(DEVICE_OBJECT *device, IRP *irp)
{
    /* All these are handled by the lower level driver */
    IoSkipCurrentIrpStackLocation(irp);
    return IoCallDriver(((HID_DEVICE_EXTENSION *)device->DeviceExtension)->NextDeviceObject, irp);
}
--- snip ---

The function in winebus also has tracing for unsupported ioctls for example.
Does that make sense, or do you prefer to keep the IoControlCode checks
(even if we do not seem to need them yet).

Regards,
Sebastian