Re: [PATCH vkd3d 4/4] vkd3d-shader: Introduce struct vkd3d_shader_hlsl_source_info.

[Zebediah Figura]

On 9/25/20 8:01 AM, Henri Verbeet wrote:
> On Fri, 25 Sep 2020 at 03:00, Zebediah Figura  wrote:
> > - /**
> > -
> > * Optional pointer to another compiled shader. This parameter must point to
> > -
> > * a valid shader if any of the following compilation options are used:
> > -
> > * - VKD3D_SHADER_COMPILE_OPTION_HLSL_MERGE_UAV_SLOTS
> > -
> > * - VKD3D_SHADER_COMPILE_OPTION_HLSL_PRESERVE_TEMPLATE_SLOTS
> > -
> > * - VKD3D_SHADER_COMPILE_OPTION_HLSL_REQUIRE_TEMPLATE_MATCH
> > -
> > * If none of the above options are used, this parameter is ignored.
> > -
> > */
> > - struct vkd3d_shader_code secondary_code;
>
> Does the secondary code need to be in any particular format?

Presumably D3DCompile2() only supports SM4-5 shaders here. We might want
to support other things, but it's not obvious to me we'd want to account
for a format other than the target type.