On 6/29/21 3:14 PM, Rémi Bernon wrote:
On 6/29/21 7:10 PM, Zebediah Figura (she/her) wrote:
This causes failures on my 64-bit Windows 7 VM; apparently KeInitializeSpinLock isn't actually exported from ntoskrnl until Windows 8.
I'm surprised that Marvin didn't report any failure. Should I then initialize the spinlock with 0?
I believe Marvin didn't report any failure because the only 64-bit machine that can run tests is the one with test-signing enabled, which runs Windows 10. But I still usually use my Windows 7 machine (which also has test-signing enabled) for all the tests and I'd appreciate being able to continue doing that ;-)
Windows conditionally (and the condition is big and terrible) defines KeInitializeSpinLock as an inline function. I think it'd be reasonable for us to do that unconditionally.