Re: sysparams: slight optimsation for IDA

[Dmitry Timoshkov]

"Andrew de Quincey"  wrote:
> Oops, sorry, didn't notice those had crept in. New version ASAP.

I'm sorry, but I'm afarid the new patch is not enough.

Here are a couple of snippets:

1. the second '+' adds a non-epmty line (and this repeats
over the whole patch):
> - spi_idx = SPI_GETNONCLIENTMETRICS;
> -

2. an unnecessary formatting change (new comment is OK):
> if (lpnm->cbSize == sizeof(NONCLIENTMETRICSA))
> {
> - /* clear the struct, so we have 'sane' members */
> - memset(
> - (char *)pvParam + sizeof(lpnm->cbSize),
> - /* clear the supplied struct, so we have 'sane' members */
> - memset((char *)pvParam + sizeof(lpnm->cbSize),

3. the whole case for IconTitleFaceName might be replaced by

spi_idx = SPI_GETICONTITLELOGFONT;
if (spi_loaded[spi_idx])
{
    memcpy(lpLogFont, &iconTitleLogFont, sizeof(LOGFONTA));
    break;
}

leaving the old code as is.