On 03/16/2018 05:40 AM, Alex Henrie wrote:
Missatge de Michael Stefaniuc mstefani@winehq.org del dia dj., 15 de març 2018 a les 13:40:
On 03/15/2018 06:11 AM, Alex Henrie wrote:
Signed-off-by: Alex Henrie alexhenrie24@gmail.com
This test has been failing on the Windows 7 testbot since February 26, likely because of a Windows update.
Heh, that's when I added that test: git log 9ae8b8c00f2c dlls/dmstyle/
So I'm ignoring that issue as it will go away.
Understood, thanks for the explanation. If setting DMUS_OBJ_VERSION is not
It is not setting that, it fresh objects are created with that outside the control of the app.
necessarily wrong, it might be a good idea to take the patch anyway. At the
It is more for documenting inconsistencies between the different IDirectMusicObject implementations. So I'd rather add another broken or so.
very least, the patch improves the failure message to match what was actually tested. But I defer to the sole guru of DirectMusic ;-)
My gut feeling tells me something else is wrong, some unitialized memory or maybe reuse of a previous object, who knows. The non-reproducible part during manual test runs makes it very annoying to troubleshoot. There's some time until Jeremy comes after me at WineConf so I'd rather keep it at least until I get to cleanup dmstyle.
bye michael