Hello folks,
* On 2021-10-07 22:53, Ted Lyngmo wrote:
misc.c:550: Test failed: 9 should be blank
I can't figure out how I broke "test_isblank" with my patch. That test looks unrelated to anything that has to do with fopen(). Perhaps it becomes obvious after some sleep :-)
I'd use debugger and try adding two breakpoints: one at the misc.c:550 (or misc.c:1552) and when it the stops, the second one at the start of your newly added code. And then I'd try stepping into/over the used subroutines.
Then all "Win1909+" and "Win10" bot runs contains similar failure [1]:
--- quote --- dlls/ucrtbase/tests/misc.c
1b34:misc: 2 tests executed (0 marked as todo, 0 failures), 0 skipped. misc.c:550: Test failed: 9 should be blank 16d4:misc: 198552 tests executed (0 marked as todo, 1 failure), 0 skipped. ucrtbase:misc:16d4 done (1) in 0s --- quote ---
And all "Win10L" runs has it too plus more [2]:
--- quote --- dlls/ucrtbase/tests/misc.c
1d04:misc: 2 tests executed (0 marked as todo, 0 failures), 0 skipped. misc.c:550: Test failed: 9 should be blank misc.c:799: Test failed: fma(inf, 0.000000, 0.000000) got errno -1 misc.c:799: Test failed: fma(0.000000, inf, 0.000000) got errno -1 misc.c:799: Test failed: fma(inf, 1.000000, -inf) got errno -1 misc.c:799: Test failed: fma(-inf, 1.000000, inf) got errno -1 misc.c:799: Test failed: fma(1.000000, inf, -inf) got errno -1 misc.c:799: Test failed: fma(1.000000, -inf, inf) got errno -1 0eec:misc: 198552 tests executed (0 marked as todo, 7 failures), 0 skipped. ucrtbase:misc:0eec done (7) in 0s --- quote ---
This happens since at least 2021-07-27. [4] Also please note the change in pattern of error count for these OS versions: [5]
... 1, 1, 7 1, 7, 7 1, 7, 1 ...
--- quote --- 1cddd8d5715d Aug 31 0 0 0 0 1 1 7 1 shortlog 21c4a2543796 Aug 30 0 0 0 0 1 1 7 1 shortlog 8e2df64cf897 Aug 27 0 0 0 0 1 7 7 1 shortlog 07ecdf6ce275 Aug 26 0 0 0 0 1 7 1 1 shortlog 4a18232e455d Aug 25 0 0 0 0 1 7 1 1 shortlog --- quote ---
Might be worth investigating the native environments first. Maybe the DLL versions or changes in guest OS templates? (Ccing Francois too, just in case)
S.
[1] http://test.winehq.org/data/5636088871714f2a2de9e543eb66f944ce188edc/win2004... [2] http://test.winehq.org/data/5636088871714f2a2de9e543eb66f944ce188edc/win21H1... [3] http://test.winehq.org/data/tests/ucrtbase:misc.html [4] https://web.archive.org/web/20210923213413/http://test.winehq.org/data/f1023... [5] https://test.winehq.org/data/tests/ucrtbase:misc.html#:~:text=8e2df64cf897,s...