Jaime Rave wrote:
Anything wrong with this patch?? It helps a lot in MSN Messenger and some other programs.
http://www.winehq.org/pipermail/wine-patches/2009-October/080539.html
Jaime Rave Torrres
It looks like your patch does two separate things. You should always break your patches up to solve one specific problem each. Among other things, this makes regression testing easier.
I'm not familiar with the code you're modifying, but if it's possible to test the behavior you're correcting via the Windows API, please write tests to do so. Since you're modifying winex11.drv, you'll want to look into other areas of Wine that are affected by this change. Perhaps some image loading function in another module can be used to verify the behavior.
This is less important, but you're not following the code conventions of the surrounding code. The surrounding code does not have spaces around function parameters, so yours shouldn't either.
Good luck, Andrew