| + /* psfi is NULL normally to query EXE type, if not none of the
below makes
| + sense anyway. Windows allows this and just returns FALSE
*/
| + if (psfi != NULL) return FALSE;
this is obviously wrong (psfi is dereferenced in the remainder of the function). I just wonder if it should be removed, or is here a typo and should != be == ?
Its a typo - I suspect I coded and tested it as if (!psfi) return false and 'tidied' it up incorrectly at the last minute. If should (obviously!) say "if (psfi == null) return FALSE;"
Sincere apologies for this - repeat after me... I must re-test on the very final version of the patch....:-)
Could I ask you to patch it though, as I will not get to do it until Tues otherwise (I'll do it then if you havent before).
Jason