On Thu, 24 Oct 2019 at 09:42, Marvin testbot@winehq.org wrote:
=== debian10 (32 bit report) ===
d3d8: device.c:1735: Test failed: Got unexpected hr 0x88760868. device.c:1737: Test failed: Got unexpected hr 0x88760869. device.c:1743: Test failed: Reset failed, hr 0x88760868. device.c:1745: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1751: Test failed: Reset failed, hr 0x88760868. device.c:1753: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1760: Test failed: Failed to reset device, hr 0x88760868. device.c:1767: Test failed: Failed to reset device, hr 0x88760868. device.c:1781: Test failed: Reset failed, hr 0x88760868. device.c:1784: Test failed: GetDepthStencilSurface failed, hr 0x88760866. device.c:1785: Test failed: Depth / stencil buffer should not be NULL. device.c:1790: Test failed: Reset failed, hr 0x88760868. device.c:1802: Test failed: Reset failed, hr 0x88760868. device.c:1804: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1813: Test failed: Reset failed, hr 0x88760868. device.c:1815: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1822: Test failed: Reset failed, hr 0x88760868. device.c:1824: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1836: Test failed: Reset failed, hr 0x88760868. device.c:1838: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1844: Test failed: Reset failed, hr 0x88760868. device.c:1856: Test failed: Reset returned 0x88760868, expected 0x8876086c. device.c:1867: Test failed: Reset returned 0x88760868, expected 0x8876086c. device.c:1878: Test failed: Reset returned 0x88760868, expected 0x8876086c.
As it turns out, the testbot is right about this one. This issue seems to be that while wined3d_device_reset() cleans up stateblock references before enumerating potentially blocking resources, d3d8_device_Reset() doesn't.