Re: [PATCH] kernelbase: Implement GEO_FRIENDLYNAME for GetGeoInfoW()

[Alexandre Julliard]

Aaro Altonen  writes:
> - if ((LANGIDFROMLCID(GetSystemDefaultLCID()) != MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US)) ||
> -
>    (LANGIDFROMLCID(GetThreadLocale()) != MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US)))
> - {
> -
>    skip("Non US-English locale\n");
> - }

This shows that the strings will have to be stored in resources so that
they can be translated.
> - else
> - {
> -
>    buffA[0] = 0;
> -
>    ret = pGetGeoInfoA(203, GEO_FRIENDLYNAME, buffA, 20, 0);
> -
>    ok(ret == 7, "got %d, expected 7\n", ret);
> -
>    ok(!strcmp(buffA, "Russia"), "got %s, expected Russia\n", buffA);
> -
> -
>    /* Kosovo does not have a friendly name (except on win10) */
> -
>    SetLastError(0xdeadbeef);
> -
>    buffA[0] = 0;
> -
>    ret = pGetGeoInfoA(9914689, GEO_FRIENDLYNAME, buffA, 20, 0);
> -
>    ok(ret == 0 || broken(ret == 7) /* win10 */, "got %d, expected 0\n", ret);

It seems to me that it's the missing name case that should be considered
broken.