Re: [3/4] msvcp120/tests: Add file_size test.

[YongHao Hu]

Hi,
I am sorry that I ignored this case as I had implemented file_size and 
equivalent functions in my machine.
Except of this, the test looks good for me, how do you think about it ?
Thank you.

On 2015年03月18日 06:02, Piotr Caban wrote:
> Hi,
>
> On 17/03/15 16:41, YongHao Hu wrote:
> > +static void test_tr2_sys_file_size(void)
> > +{
> > - unsigned long long val;
> > - val = p_tr2_sys_file_size("dir/d1/d1f1");
> > - ok(val==0, "test fail: file_size is %llu\n", val);
>
> The tests needs to pass on wine. You can test your patch by running 
> `make test` in dlls/msvcp120/tests directory. Because of that you 
> can't test a function that is defined as stub in spec file. 
> GetProcAddress will load such function but when called stub will cause 
> an exception. When the function is implemented you can add tests that 
> doesn't work on wine and mark them with todo_wine.
>
> Thanks,
> Piotr