Re: [PATCH v11 1/2] ntdll: Clarify NtAllocateVirtualMemory zero_bits parameter semantics

[Huw Davies]

On Wed, Jun 12, 2019 at 10:59:44AM +0200, Rémi Bernon wrote:
> +/***********************************************************************
> -
> -
>         virtual_alloc_aligned   (NTDLL.@)
> -
> -
> -
> - Same as NtAllocateVirtualMemory but with an alignment parameter
> - */
>
> +NTSTATUS virtual_alloc_aligned( PVOID *ret, ULONG zero_bits, SIZE_T *size_ptr,
> -
>                            ULONG type, ULONG protect, ULONG alignment )
>
> +{
> - void *base;
> - unsigned int vprot;
> - SIZE_T size = *size_ptr;
> - SIZE_T mask = get_mask( alignment );
> - NTSTATUS status = STATUS_SUCCESS;
> - BOOL is_dos_memory = FALSE;
> - struct file_view *view;
> - sigset_t sigset;
> -
> - if (zero_bits)
> - {
> -
>    FIXME("Unimplemented zero_bits parameter value\n");
> - }
> -

Actually let's put this in map_view() since that is supposed to handle
this.  Obviously this patch needs to be extended to also include
passing zero_bits to that function.

Huw.