Re: [PATCH 3/5] wined3d: Pass a wined3d_device_context to wined3d_shader_resource_view_generate_mipmaps().

[Henri Verbeet]

On Thu, 8 Apr 2021 at 04:20, Zebediah Figura  wrote:
> -void CDECL wined3d_shader_resource_view_generate_mipmaps(struct wined3d_shader_resource_view *view)
> +void CDECL wined3d_device_context_generate_mipmaps(struct wined3d_device_context *context,
> -
>    struct wined3d_shader_resource_view *view)
>
> {
>      struct wined3d_texture *texture;
> - TRACE("view %p.\n", view);
> -
>
> TRACE("context %p, view %p.\n", context, view);
>
> if (view->resource->type == WINED3D_RTYPE_BUFFER)
> {
>
> @@ -1423,7 +1424,7 @@ void CDECL wined3d_shader_resource_view_generate_mipmaps(struct wined3d_shader_r
>          return;
>      }
> - wined3d_device_context_emit_generate_mipmaps(&view->resource->device->cs->c, view);
> - wined3d_device_context_emit_generate_mipmaps(context, view);
>
> }

It would probably make sense to move this to device.c. (Or arguably
cs.c, but in that case some of the device context functions currently
in device.c would need to be moved to cs.c as well.)