Re: [PATCH 2/5] wined3d: Introduce resource-type specific format flags.

[Henri Verbeet]

On 23 April 2015 at 11:28, Stefan Dösinger  wrote:
> -
>    /* Always check 2D textures here, we don't want to write this ERR when the app tried
> -
>     * to create a compressed volume texture but s3tc support is otherwise available. */
>    if ((desc->format == WINED3DFMT_DXT1 || desc->format == WINED3DFMT_DXT2 || desc->format == WINED3DFMT_DXT3
>            || desc->format == WINED3DFMT_DXT4 || desc->format == WINED3DFMT_DXT5)
> -
>            && !(format->flags & WINED3DFMT_FLAG_TEXTURE) && !once++)
> -
>            && !(format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_TEXTURE) && !once++)
>        ERR_(winediag)("The application tried to create a DXTn texture, but the driver does not support them.\n");

But now it's still going to write an ERR when it tries to create a
volume texture and s3tc support is unavailable. Wouldn't it make more
sense to just explicitly exclude volume textures by adding a
"desc->resource_type != WINED3D_RTYPE_VOLUME_TEXTURE" condition?