On 25 January 2012 01:25, Francois Gouget fgouget@free.fr wrote:
I don't pretend to know what Henry meant but reported_once is not initialized. It's probably put into a zero-initialized section by the compiler but it looks worrying to me (I believe something like this has been debated on the Linux kernel mailing list).
Variables with static storage duration (mostly globals and things marked static) are zero-initialized before program startup unless explicitly initialized. That also means they are typically placed in .bss, which I guess is what you're referring to with the lkml discussion.
The code looks like it would do what was intended to me. The problem I have with it, and I'm pretty sure I've mentioned this before, is that reducing debug output shouldn't be a goal on its own. If you're a user, and the messages make you feel scared/sad/whatever, just use WINEDEBUG=-all, or even WINEDEBUG=-d3d if the other messages do make you happy. If you're a developer, just fix the actual problem already.