Hello Alex,
I'll have a go at reviewing your patches as Alexandre didn't take them as is.
On 10/13/2014 05:54 AM, Alex Henrie wrote:
--- a/dlls/kernel32/locale.c +++ b/dlls/kernel32/locale.c
I'm pulling this diff chunk to the front as it is wrong and some of your code is over-complicated based on that assumption.
@@ -1963,7 +2119,7 @@ BOOL WINAPI EnumSystemCodePagesW( CODEPAGE_ENUMPROCW lpfnCodePageEnum, DWORD fla
- flags [I] Character mapping flags
- src [I] Source string buffer
- srclen [I] Length of src (in bytes), or -1 if src is NUL terminated
- dst [O] Destination buffer
- dst [O] Destination buffer, or NULL to compute the required length
- dstlen [I] Length of dst (in WCHARs), or 0 to compute the required length
The only case where dst == NULL is when dstlen == 0 but that already implies computing the required length. dst == NULL and dstlen != 0 is an error and MultiByteToWideChar() bails out.
@@ -1954,6 +1954,162 @@ BOOL WINAPI EnumSystemCodePagesW( CODEPAGE_ENUMPROCW lpfnCodePageEnum, DWORD fla
/***********************************************************************
write_to_w_string
- Helper for utf7_mbstowcs
- RETURNS
- TRUE on success, FALSE on error
- */
+static inline BOOL write_to_w_string(WCHAR *dst, int dstlen, int *index, WCHAR character)
This isn't a good name for the helper as that's not what it does. It is more a "count and optionally write". Also prefixing it utf7 would make it clear that is just a helper for utf7_mbstowcs and not a generic function and thus would remove the need for the comment that it is just a helper for utf7_mbstowcs.
I know you're using this helper to avoid code duplication between the length calculation and the conversion unlike wine_utf8_mbstowcs(). But it complicates the handling of available space in dst. Without seeing the code for both approaches I'm not sure what is best so I'll review it as is.
+{
- if (dst)
You have to force dst = NULL in utf7_mbstowcs() for this to work. Just checking for dstlen > 0 should avoid that.
- {
if (*index >= dstlen)return FALSE;dst[*index] = character;- }
- (*index)++;
- return TRUE;
+}
+/***********************************************************************
utf7_mbstowcs
- UTF-7 to UTF-16 string conversion, helper for MultiByteToWideChar
- RETURNS
- On success, the number of characters written
- On dst buffer overflow, -1
What about the case where it fails to decode a character? E.g. wine_utf8_mbstowcs() has -2 for that case which then translates to SetLastError(ERROR_NO_UNICODE_TRANSLATION). I looked at the tests but you didn't seem to test the GetLastError in the cases with the invalid input characters.
- */
+static int utf7_mbstowcs(const char *src, int srclen, WCHAR *dst, int dstlen) +{
- static const WCHAR base64_decoding_table[] = {
Why is this table an array of WCHAR? The entries aren't WCHARs.
/* \0 */ -1, /* \x01 */ -1, /* \x02 */ -1, /* \x03 */ -1,
This table is really hard to read even in a editor that does syntax highlighting. As you just need 4 characters per column you could have sixteen columns and merge the comments to one comment at the end of the line. Something like this would be more readable as well as being more compact: -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, /* 0x00 - 0x15 */ .... /* '0' - '?' */
/* \x04 */ -1, /* \x05 */ -1, /* \x06 */ -1, /* \a */ -1,/* \b */ -1, /* \t */ -1, /* \n */ -1, /* \v */ -1,/* \f */ -1, /* \r */ -1, /* \x0E */ -1, /* \x0F */ -1,/* \x10 */ -1, /* \x11 */ -1, /* \x12 */ -1, /* \x13 */ -1,/* \x14 */ -1, /* \x15 */ -1, /* \x16 */ -1, /* \x17 */ -1,/* \x18 */ -1, /* \x19 */ -1, /* \x1A */ -1, /* \e */ -1,/* \x1C */ -1, /* \x1D */ -1, /* \x1E */ -1, /* \x1F */ -1,/* */ -1, /* ! */ -1, /* " */ -1, /* # */ -1,/* $ */ -1, /* % */ -1, /* & */ -1, /* ' */ -1,/* ( */ -1, /* ) */ -1, /* * */ -1, /* + */ 62,/* , */ -1, /* - */ -1, /* . */ -1, /* / */ 63,/* 0 */ 52, /* 1 */ 53, /* 2 */ 54, /* 3 */ 55,/* 4 */ 56, /* 5 */ 57, /* 6 */ 58, /* 7 */ 59,/* 8 */ 60, /* 9 */ 61, /* : */ -1, /* ; */ -1,/* < */ -1, /* = */ -1, /* > */ -1, /* ? */ -1,/* @ */ -1, /* A */ 0, /* B */ 1, /* C */ 2,/* D */ 3, /* E */ 4, /* F */ 5, /* G */ 6,/* H */ 7, /* I */ 8, /* J */ 9, /* K */ 10,/* L */ 11, /* M */ 12, /* N */ 13, /* O */ 14,/* P */ 15, /* Q */ 16, /* R */ 17, /* S */ 18,/* T */ 19, /* U */ 20, /* V */ 21, /* W */ 22,/* X */ 23, /* Y */ 24, /* Z */ 25, /* [ */ -1,/* \ */ -1, /* ] */ -1, /* ^ */ -1, /* _ */ -1,/* ` */ -1, /* a */ 26, /* b */ 27, /* c */ 28,/* d */ 29, /* e */ 30, /* f */ 31, /* g */ 32,/* h */ 33, /* i */ 34, /* j */ 35, /* k */ 36,/* l */ 37, /* m */ 38, /* n */ 39, /* o */ 40,/* p */ 41, /* q */ 42, /* r */ 43, /* s */ 44,/* t */ 45, /* u */ 46, /* v */ 47, /* w */ 48,/* x */ 49, /* y */ 50, /* z */ 51, /* { */ -1,/* | */ -1, /* } */ -1, /* ~ */ -1, /* \x7F */ -1- };
- const char *source_end = src + srclen;
- int dest_index = 0;
- DWORD byte_pair = 0;
- short offset = 0;
- /* MultiByteToWideChar guarantees that srclen > 0 */
- assert(srclen > 0);
This assert isn't needed. Just rewriting the first do..while loop to a while loop avoids it. That eliminates 3 lines of code of which one is a comment pointing to an unneeded assert.
- if (!dstlen)
dst = NULL;
Unneeded if the helper just checks for dstlen > 0.
- do
Should be just "while (src < source_end)" to avoid the assert from above.
- {
if (*src == '+'){src++; /* skip the + sign */if (src >= source_end)break;if (*src == '-'){/* just a plus sign escaped as +- */if (!write_to_w_string(dst, dstlen, &dest_index, '+'))return -1;src++;continue;}do{WCHAR sextet = *src;
Same as for base64_decoding_table, sextet is not a WCHAR.
if (sextet == '-'){/* skip over the dash and end base64 decoding *//* the current, unfinished byte pair is discarded */src++;offset = 0;break;}else if (sextet <= 127){sextet = base64_decoding_table[sextet];if (sextet == (WCHAR)-1)
Unneeded cast. Using a signed type for sextet also avoids the -Wsign-compare compiler warning. Alternatively use ~0 instead of -1 if you want to keep an unsigned type.
{/* -1 means that the next character of src is not part of a base64 sequence */
This upper part of the comment is better placed in the declaration of base64_decoding_table.
/* in other words, all sextets in this base64 sequence have been processed *//* the current, unfinished byte pair is discarded */offset = 0;break;}}else{/* the next character of src is > 127 and therefore not part of a base64 sequence *//* the current, unfinished byte pair is NOT discarded in this case *//* this is probably a bug in Windows */break;}byte_pair = (byte_pair << 6) | sextet;offset += 6;if (offset >= 16){/* this byte pair is done */if (!write_to_w_string(dst, dstlen, &dest_index, (byte_pair >> (offset - 16)) & 0xFFFF))return -1;offset -= 16;}/* this sextet is done */src++;} while (src < source_end);}else{/* we have to convert to unsigned char in case *src > 127 */if (!write_to_w_string(dst, dstlen, &dest_index, (unsigned char)*src))return -1;src++;}- } while (src < source_end);
- return dest_index;
+}
+/***********************************************************************
MultiByteToWideChar (KERNEL32.@)- Convert a multibyte character string into a Unicode string.
bye michael