Hi Huw,
yes I saw the failure, though fixing it only requires to remove a todo_wine. My idea was to await, if you have some other points which need to be changed about the patch series, so I can resend with those changes and the fixed test, to not spam the mailing list too much.
Bernhard
Huw Davies huw@codeweavers.com schrieb am Mo., 24. Jan. 2022, 09:30:
On Thu, Jan 13, 2022 at 12:34:14AM +0100, Bernhard Kölbl wrote:
The goal of these tests is to show, that the memory layout of hstring_private is different on Windows, than currently used in Wine. This creates issues with the WinRT SDK, which allocates HSTRINGs without using the functions provided by the combase dll.
Signed-off-by: Bernhard Kölbl besentv@gmail.com
dlls/combase/tests/string.c | 80 +++++++++++++++++++++++++++++++++++++ 1 file changed, 80 insertions(+)
diff --git a/dlls/combase/tests/string.c b/dlls/combase/tests/string.c index 5ebf669a426..713f08d342b 100644 --- a/dlls/combase/tests/string.c +++ b/dlls/combase/tests/string.c @@ -479,6 +479,85 @@ static void test_trim(void) ok(WindowsDeleteString(str1) == S_OK, "Failed to delete string\n"); }
Did you see that this had test failures?
https://testbot.winehq.org/JobDetails.pl?Key=105204
Huw.