Am 11.01.2022 um 19:16 schrieb Gabriel Ivăncescu gabrielopcode@gmail.com:
wrt the window size—I thought exiting fullscreen resized the window back to its original size? Granted that's not tested because I thought it was redundant. But yes, more or less I wanted to test the fact that the window does get fullscreen, just not topmost.
Not in ddraw afaics - see WINED3D_SWAPCHAIN_RESTORE_WINDOW_RECT . I was skimming the test for a test that explicitly tests this and didn't immediately find one. I'll check on Windows after a slow download finishes...
There are some tests that *might* accidentally test this, or might think they test it but do not because previous SetCoopLevel / SetDisplayMode / RestoreDisplayMode / Release ops on the window leave the window with the "right" size by accident.
As for "no window changes", I think this is intentional. wined3d's "no window changes" flag does the same thing: it only applies to visibility changes and topmost, not size, which is similar among different APIs so it must be something common on what Microsoft considers here "window changes" I guess.
Sounds good. Let's make sure the test verifies that for ddraw and then I think I am happy with the ddraw changes.