Re: comctl32: Use SetRect() instead of open coding it.

[Michael Stefaniuc]

On 04/29/2016 03:24 PM, Sebastian Lackner wrote:
> On 29.04.2016 15:21, Michael Stefaniuc wrote:
> > - rcDragIcon.left = rcListBox.left - DRAGICON_HOTSPOT_X;
> > - rcDragIcon.top = rcItem.top - DRAGICON_HOTSPOT_Y;
> > - rcDragIcon.right = rcListBox.left;
> > - rcDragIcon.bottom = rcDragIcon.top + DRAGICON_HEIGHT;
> > - SetRect(&rcDragIcon, rcListBox.left - DRAGICON_HOTSPOT_X, rcItem.top - DRAGICON_HOTSPOT_Y,
> > -
> >        rcListBox.left, rcDragIcon.top + DRAGICON_HEIGHT);
>
> This won't work as expected. Haven't checked if there are more similar cases.

Argghh! Missed that one.
For whatever reason the coccinelle rule to prevent this isn't catching
it if it happens in the last argument to the function call.  I had
manually eliminated two other cases like this but missed this one.

bye
    michael