Re: d3dx9_36 [patch 2/5]: Implement D3DXSHEvalHemisphereLight

[Rico Schüller]

On 09.10.2012 09:49, Nozomi Kodama wrote:
> +HRESULT WINAPI D3DXSHEvalHemisphereLight(UINT order, CONST D3DXVECTOR3 *dir, D3DXCOLOR top, D3DXCOLOR bottom, FLOAT *rout, FLOAT *gout, FLOAT *bout)

The number of columns used for the code seems to be a little high again.
> -
>            if (j >= 4 && j < order * order)
> -
>                expected = 0.0f;
> -
>            else if ( j >= order * order )

I'd use "if (x == y)" without spaces on all occurrences... there are a 
couple of them in the patch.

Cheers
Rico