Re: [PATCH 1/5] ddraw/tests: Accept nvidia return values in test_rt_caps.

[Henri Verbeet]

On 25 October 2013 00:47, Stefan Dösinger  wrote:
> dlls/ddraw/tests/ddraw2.c | 26 ++++++++++++++++++++++++--
>  dlls/ddraw/tests/ddraw7.c | 27 ++++++++++++++++++++++++---
>  2 files changed, 48 insertions(+), 5 deletions(-)
>
> diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c
> index f4702f1..801135d 100644
> --- a/dlls/ddraw/tests/ddraw2.c
> +++ b/dlls/ddraw/tests/ddraw2.c
> @@ -3663,6 +3663,7 @@ static void test_rt_caps(void)
>          DWORD caps_out;
>          HRESULT create_device_hr;
>          HRESULT set_rt_hr;
> -
>    HRESULT alternative_set_rt_hr;
> }
>    test_data[] =
>    {

This kind of construction doesn't generally make me very happy, but on
the other hand I'm not sure I can come up with something that's much
better either. I do think we should mark the alternative results as
broken. Some of the Evergreen results in later patches in this series
are a bit surprising to me. I wrote the test on Windows 7 / AMD
Cayman, which should be very close to Evergreen hardware.