Re: [PATCH] wineqtdecoder: Use nameless unions.

[Jacek Caban]

On 3/24/21 7:17 PM, Gijs Vermeulen wrote:
> Fixes a regression caused by b39b9eea39b19a8f91543b8350ed822d0fd9eef0.
> Signed-off-by: Gijs Vermeulen
>
> Superseeds 202416.
>
> dlls/wineqtdecoder/main.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/dlls/wineqtdecoder/main.c b/dlls/wineqtdecoder/main.c
> index 435951ba933..da577f82714 100644
> --- a/dlls/wineqtdecoder/main.c
> +++ b/dlls/wineqtdecoder/main.c
> @@ -188,8 +188,8 @@ static const REGFILTER2 reg_qt_splitter =
>   {
>       .dwVersion = 2,
>       .dwMerit = MERIT_NORMAL - 1,
> - .u.s2.cPins2 = 3,
> - .u.s2.rgPins2 = reg_qt_splitter_pins,
> -
>
> .cPins2 = 3,
> -
>
> .rgPins2 = reg_qt_splitter_pins,
> };
>
> static const REGFILTERPINS2 reg_video_decoder_pins[2] =
>
> @@ -209,8 +209,8 @@ static const REGFILTER2 reg_video_decoder =
>   {
>       .dwVersion = 2,
>       .dwMerit = MERIT_NORMAL - 1,
> - .u.s2.cPins2 = 2,
> - .u.s2.rgPins2 = reg_video_decoder_pins,
> - .cPins2 = 2,
> - .rgPins2 = reg_video_decoder_pins,

I didn't expect it to use designated initializers, so gave you wrong 
advise, sorry. If we want to continue using them, we will need 
WINE_NO_NAMELESS_EXTENSION in this case.

Jacek