Re: [PATCH] bcrypt: Allow importing private ECDSA keys.

[Derek Lesho]

On 7/10/20 3:43 PM, Hans Leidekker wrote:
> On Fri, 2020-07-10 at 14:16 -0500, Derek Lesho wrote:
> > diff --git a/dlls/bcrypt/bcrypt_main.c b/dlls/bcrypt/bcrypt_main.c
> > index fee40ebe8d..f4e59734cc 100644
> > --- a/dlls/bcrypt/bcrypt_main.c
> > +++ b/dlls/bcrypt/bcrypt_main.c
> > @@ -1201,6 +1201,10 @@ static NTSTATUS key_import_pair( struct algorithm *alg, const WCHAR *type, BCRYP
> >               key_size = 32;
> >               magic = BCRYPT_ECDH_PRIVATE_P256_MAGIC;
> >               break;
> > -
> >    case ALG_ID_ECDSA_P256:
> > -
> >        key_size = 32;
> > -
> >        magic = BCRYPT_ECDSA_PRIVATE_P256_MAGIC;
> > -
> >        break;
>
> Wouldn't this need a corresponding change in key_import_ecc?

To be honest, I'm not sure.  I don't remember writing this code, I think 
the patch was necessary for halo MCC, and it has been in Proton since 
December.