Re: oleaut32: Added debugstr_variant helper for better debug traces.

[Michael Stefaniuc]

Hello Jacek,

On 05/14/2014 04:55 PM, Jacek Caban wrote:
> 0001-oleaut32-Added-debugstr_variant-helper-for-better-deb.diff

wouldn't it be better to make debugstr_variant aka add it to
include/wine/debug.h? VARIANTs are used in a lot more places then just
oleaut32.
> diff --git a/dlls/oleaut32/varformat.c b/dlls/oleaut32/varformat.c
> index e72a170..0e1c370 100644
> --- a/dlls/oleaut32/varformat.c
> +++ b/dlls/oleaut32/varformat.c
> @@ -1201,9 +1201,8 @@ static HRESULT VARIANT_FormatNumber(LPVARIANT pVarIn, LPOLESTR lpszFormat,
>    const BYTE* pToken = NULL;
>    HRESULT hRes = S_OK;
> - TRACE("(%p->(%s%s),%s,%p,0x%08x,%p,0x%08x)\n", pVarIn, debugstr_VT(pVarIn),
> -
>    debugstr_VF(pVarIn), debugstr_w(lpszFormat), rgbTok, dwFlags, pbstrOut,
> -
>    lcid);
> - TRACE("(%s,%s,%p,0x%08x,%p,0x%08x)\n", debugstr_variant(pVarIn), debugstr_w(lpszFormat),
> -
>    rgbTok, dwFlags, pbstrOut, lcid);

bye
    michael