Shouldn't it use strmbase?
You mean the methods that for example quartz/nullrenderer.c uses in NullRenderer_Vtbl? I'm not sure, that's why I just stubbed them.
I mean BaseFilter from strmbase.
Ah you mean I shouldn't implement this interface by myself, but just return a BaseFilter object? I'm not sure how I would test against that to make sure it actually is a BaseFilter and not something different.
This needs at test for aggregation support.
Sorry I don't know what you mean. Care to elaborate?
I mean a test to show if it's supported or not. Currently you ignore outer interface argument. Take a look at qcap for example.
I see, I never heard of COM aggregation before, so I first need to read into it.
I mean if there's no reason, why should it be in a header.
Using just "%p" is enough for pointers, you don't need extra prefix.
I personally don't think d3dxof is a good place to look for examples. But anyway copied parts should get some cleanup and not be taken for granted. XF prefix for example could possibly be an acronym for directXFile, and that does not apply to anything but d3dxof.
Makes sense, I will rework that.
Regards, Fabian Maurer