Got it, made that change and sent it to wine-patches.
Cheers, Jam
On Thu, Aug 20, 2015 at 2:20 PM, Stefan Dösinger stefandoesinger@gmail.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-08-20 um 10:42 schrieb Stefan Dösinger:
I don't think you need the NULL assignment here, d3ddevice::queryinterface does it for you in all error paths.
Just to clarify: Setting *obj = NULL if the requested interface isn't supported is documented QueryInterface behavior[1]. Some interfaces beg to differ, but IDirect3DDevice* works according to the spec.
1:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms682521(v=vs.85).a... -----BEGIN PGP SIGNATURE----- Version: GnuPG v2
iQIcBAEBAgAGBQJV1ZTFAAoJEN0/YqbEcdMwmLUQAIj8w0Kw0pkReFSlXbPmZ9th Cn/dOFRehwYtwCS7ZCC5L83KowOrGiTKp/CxxhX0eF+UoQo71PIzOqPe3Bxbbz0B yDfHTvDSXkk4zBrfISL5cVioQwcmYD1pfjaQP8BBMZvBd83Ve4pYSLPMbubgBe+p 6rRShZZMQBcE2z1jxED3jISMBk6pkAeTVdNVs6ukA/Is0nCOOLNFJZ4ygXBv+FQR OObw2k33OjWBCkjKP3ux6bdvPpsCLcrwLVbZxqamUge1JwTlkP6umzZK2GamaQJY AF7RBIV6L2qeA4dCe30OFFThqWj/nRo1yVnKe7TJSs/USl+m2AiukTUE8D7WMQWs Pdk0mT8/decvB8ESWgShlfdELSqqICB4OTqev8bL3ruW+s8W4PeyA3K4JN7bhYqA T16b+meEIdY3Q7nO0EHeU99st260mdjqHzNO3toQbZZtHTR2ESLUmCEBePIqG+wG +/9XHvScxLRoCxPbYOgMw/ujrDZUebOTwXG845O5LUFPhvAy7nTzSAKqODNyCO2n tmHNYFYlAL6ZEm+L5RWjy/Yj120kJ2h4VtxfaTNZu/33gd+0H9kIMTqAlPW7NnZE bg9+zos94n5ZTcMqQrie8HdF1HLYjA1hFPGZotKdg2qplThlpQ2XiH/mwehR7/Zf JtzjAXDG/8TRd8jYeuaN =zCME -----END PGP SIGNATURE-----