On 8 May 2012 11:21, Alex Henrie alexhenrie24@gmail.com wrote:
Hi all,
Could I get some feedback on http://source.winehq.org/patches/data/85898 ? It was marked "Rejected" a week ago without explanation.
Without being a regular contributor, here are a few tips from a cursory glance: 1) Whitespace change on at least one line 2) Why the change from ERROR_INVALID_PARAMETER to ERROR_INVALID_FLAGS? 3) New function defs do not match format of surrounding defs in unicode.h 4) No new tests to confirm the behaviour is correct (or mention of current tests succeeding)
Most of the code was authored by Katayama Hirofumi, whose patches have been accepted into Wine before. He gave permission to use his code under the LGPL at http://bugs.winehq.org/show_bug.cgi?id=27388
What more needs to be done before this patch can be accepted?
-Alex